Files
rockchip-kernel/kernel
Thomas Gleixner bf5cd0c632 genirq: Prevent chip buslock deadlock
commit abc7e40c81 upstream.

If a interrupt chip utilizes chip->buslock then free_irq() can
deadlock in the following way:

CPU0				CPU1
				interrupt(X) (Shared or spurious)
free_irq(X)			interrupt_thread(X)
chip_bus_lock(X)
				   irq_finalize_oneshot(X)
				     chip_bus_lock(X)
synchronize_irq(X)

synchronize_irq() waits for the interrupt thread to complete,
i.e. forever.

Solution is simple: Drop chip_bus_lock() before calling
synchronize_irq() as we do with the irq_desc lock. There is nothing to
be protected after the point where irq_desc lock has been released.

This adds chip_bus_lock/unlock() to the remove_irq() code path, but
that's actually correct in the case where remove_irq() is called on
such an interrupt. The current users of remove_irq() are not affected
as none of those interrupts is on a chip which requires buslock.

Reported-by: Fredrik Markström <fredrik.markstrom@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-03 15:06:20 -08:00
..
2016-03-03 15:06:20 -08:00
2013-04-22 07:09:06 -07:00
2014-11-21 09:22:52 -08:00
2013-04-15 13:25:16 +02:00
2016-02-25 11:57:50 -08:00
2013-05-05 00:16:35 -04:00
2014-07-17 15:58:04 -07:00
2014-06-07 13:25:30 -07:00