Files
rockchip-kernel/include/linux
Mel Gorman 42288fe366 mm: mempolicy: Convert shared_policy mutex to spinlock
Sasha was fuzzing with trinity and reported the following problem:

  BUG: sleeping function called from invalid context at kernel/mutex.c:269
  in_atomic(): 1, irqs_disabled(): 0, pid: 6361, name: trinity-main
  2 locks held by trinity-main/6361:
   #0:  (&mm->mmap_sem){++++++}, at: [<ffffffff810aa314>] __do_page_fault+0x1e4/0x4f0
   #1:  (&(&mm->page_table_lock)->rlock){+.+...}, at: [<ffffffff8122f017>] handle_pte_fault+0x3f7/0x6a0
  Pid: 6361, comm: trinity-main Tainted: G        W
  3.7.0-rc2-next-20121024-sasha-00001-gd95ef01-dirty #74
  Call Trace:
    __might_sleep+0x1c3/0x1e0
    mutex_lock_nested+0x29/0x50
    mpol_shared_policy_lookup+0x2e/0x90
    shmem_get_policy+0x2e/0x30
    get_vma_policy+0x5a/0xa0
    mpol_misplaced+0x41/0x1d0
    handle_pte_fault+0x465/0x6a0

This was triggered by a different version of automatic NUMA balancing
but in theory the current version is vunerable to the same problem.

do_numa_page
  -> numa_migrate_prep
    -> mpol_misplaced
      -> get_vma_policy
        -> shmem_get_policy

It's very unlikely this will happen as shared pages are not marked
pte_numa -- see the page_mapcount() check in change_pte_range() -- but
it is possible.

To address this, this patch restores sp->lock as originally implemented
by Kosaki Motohiro.  In the path where get_vma_policy() is called, it
should not be calling sp_alloc() so it is not necessary to treat the PTL
specially.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Tested-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Mel Gorman <mgorman@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-01-02 17:32:13 -08:00
..
2012-12-07 17:02:47 +00:00
2012-12-19 12:46:40 -08:00
2012-11-30 12:37:36 +01:00
2012-07-30 17:25:21 -07:00
2012-10-08 13:50:20 +10:30
2012-12-02 00:05:12 +00:00
2012-09-19 19:08:46 -06:00
2012-09-20 14:31:45 +02:00
2012-07-30 17:25:11 -07:00
2012-11-15 00:34:23 +01:00
2012-12-20 13:57:36 -05:00
2012-12-21 20:23:41 +00:00
2012-11-08 16:58:31 +01:00
2012-09-30 18:02:20 -07:00
2012-11-28 11:54:40 +01:00
2012-10-16 18:49:15 -07:00
2012-11-22 13:43:27 +09:00
2012-11-28 21:49:02 -05:00
2012-11-28 21:49:02 -05:00
2012-11-08 16:58:30 +01:00
2012-11-21 10:07:48 +01:00
2012-10-29 21:31:32 +01:00
2012-11-23 12:23:40 +01:00
2012-12-14 13:05:26 +10:30
2012-09-07 14:57:45 -04:00
2012-09-11 10:15:02 +02:00
2012-11-21 15:09:26 -08:00
2012-09-26 13:52:36 -07:00
2012-11-20 16:15:02 +10:00
2012-11-03 14:50:15 -04:00
2012-10-10 01:15:44 -04:00
2012-12-12 17:38:33 -08:00
2012-12-20 18:46:29 -05:00
2012-10-10 20:00:55 +10:30
2012-12-14 13:06:40 +10:30
2012-12-11 17:22:27 -08:00
2012-10-17 15:53:02 -05:00
2012-10-10 22:41:05 -04:00
2012-07-31 18:42:43 -07:00
2012-11-16 14:33:04 -08:00
2012-10-06 03:05:01 +09:00
2012-09-27 12:45:28 +02:00
2012-12-18 15:02:13 -08:00
2012-12-18 15:02:14 -08:00
2012-10-27 15:38:29 -07:00
2012-10-09 16:22:55 +09:00
2012-08-21 16:28:31 +02:00
2012-10-09 16:22:32 +09:00
2012-10-22 16:58:28 -07:00
2012-11-15 17:20:58 -08:00
2012-09-05 17:21:36 -07:00