Liu Yi L
18abda7a2d
iommu/vt-d: Fix general protection fault in aux_detach_device()
The aux-domain attach/detach are not tracked, some data structures might
be used after free. This causes general protection faults when multiple
subdevices are created and assigned to a same guest machine:
| general protection fault, probably for non-canonical address 0xdead000000000100: 0000 [#1] SMP NOPTI
| RIP: 0010:intel_iommu_aux_detach_device+0x12a/0x1f0
| [...]
| Call Trace:
| iommu_aux_detach_device+0x24/0x70
| vfio_mdev_detach_domain+0x3b/0x60
| ? vfio_mdev_set_domain+0x50/0x50
| iommu_group_for_each_dev+0x4f/0x80
| vfio_iommu_detach_group.isra.0+0x22/0x30
| vfio_iommu_type1_detach_group.cold+0x71/0x211
| ? find_exported_symbol_in_section+0x4a/0xd0
| ? each_symbol_section+0x28/0x50
| __vfio_group_unset_container+0x4d/0x150
| vfio_group_try_dissolve_container+0x25/0x30
| vfio_group_put_external_user+0x13/0x20
| kvm_vfio_group_put_external_user+0x27/0x40 [kvm]
| kvm_vfio_destroy+0x45/0xb0 [kvm]
| kvm_put_kvm+0x1bb/0x2e0 [kvm]
| kvm_vm_release+0x22/0x30 [kvm]
| __fput+0xcc/0x260
| ____fput+0xe/0x10
| task_work_run+0x8f/0xb0
| do_exit+0x358/0xaf0
| ? wake_up_state+0x10/0x20
| ? signal_wake_up_state+0x1a/0x30
| do_group_exit+0x47/0xb0
| __x64_sys_exit_group+0x18/0x20
| do_syscall_64+0x57/0x1d0
| entry_SYSCALL_64_after_hwframe+0x44/0xa9
Fix the crash by tracking the subdevices when attaching and detaching
aux-domains.
Fixes: 67b8e02b5e ("iommu/vt-d: Aux-domain specific domain attach/detach")
Co-developed-by: Xin Zeng <xin.zeng@intel.com>
Signed-off-by: Xin Zeng <xin.zeng@intel.com>
Signed-off-by: Liu Yi L <yi.l.liu@intel.com>
Acked-by: Lu Baolu <baolu.lu@linux.intel.com>
Link: https://lore.kernel.org/r/1609949037-25291-3-git-send-email-yi.l.liu@intel.com
Signed-off-by: Will Deacon <will@kernel.org>
2021-01-07 14:35:14 +00:00
..
2020-09-30 16:37:39 +02:00
2020-11-20 12:05:14 +01:00
2020-12-14 23:21:50 +01:00
2020-11-23 10:25:45 +01:00
2020-10-12 15:29:26 +02:00
2020-11-09 18:56:49 +01:00
2020-12-17 12:52:23 -08:00
2020-09-20 19:01:34 -07:00
2020-12-16 16:38:41 -08:00
2020-12-01 18:49:32 +01:00
2020-10-15 18:42:13 -07:00
2020-11-16 14:14:34 +02:00
2020-12-03 19:40:26 +00:00
2020-12-15 16:18:23 -08:00
2020-11-30 11:18:29 +00:00
2020-12-09 19:26:02 -06:00
2020-12-16 16:38:41 -08:00
2020-12-07 18:22:35 -08:00
2020-12-17 10:11:29 -08:00
2020-11-16 11:59:28 +01:00
2020-12-16 18:48:16 +01:00
2020-12-11 22:29:38 -08:00
2020-11-25 15:18:39 +00:00
2020-09-16 17:38:02 +05:30
2020-11-05 14:56:50 +01:00
2020-12-23 15:06:22 -08:00
2020-11-30 02:42:42 +01:00
2020-11-23 17:27:04 -08:00
2020-12-11 13:23:06 +00:00
2020-11-24 10:11:59 -06:00
2020-12-22 14:12:10 -08:00
2020-12-17 12:52:23 -08:00
2020-12-15 14:10:09 -08:00
2020-11-27 16:18:32 +00:00
2020-12-17 12:15:03 -08:00
2020-12-15 13:54:56 -08:00
2020-11-20 09:34:14 +00:00
2020-12-12 12:31:54 +01:00
2020-09-12 10:45:56 -07:00
2020-09-17 19:21:16 +02:00
2020-10-08 17:17:27 +02:00
2020-10-28 11:13:36 +00:00
2020-09-24 16:44:44 -07:00
2020-11-18 16:43:55 -08:00
2020-10-12 18:27:27 +02:00
2020-10-12 18:27:27 +02:00
2020-10-27 21:02:57 -04:00
2020-12-04 13:30:59 +01:00
2020-09-24 13:43:39 -06:00
2020-10-13 11:37:11 +02:00
2020-12-02 09:46:55 -07:00
2020-12-15 22:46:16 -08:00
2020-12-15 22:46:15 -08:00
2020-12-01 14:53:40 -07:00
2020-12-01 14:53:39 -07:00
2020-10-05 10:47:43 -06:00
2020-12-16 13:09:32 -08:00
2020-12-16 12:57:51 -08:00
2020-12-04 09:42:00 -07:00
2020-11-19 08:55:44 -05:00
2020-11-13 15:45:54 +01:00
2020-11-06 08:08:37 -08:00
2020-12-03 17:38:21 -08:00
2020-12-02 13:25:11 -08:00
2020-12-08 18:23:36 -08:00
2020-09-21 17:16:17 -07:00
2020-09-21 15:00:40 -07:00
2020-12-03 17:38:21 -08:00
2020-12-11 14:02:14 -08:00
2020-12-02 09:46:55 -07:00
2020-10-25 14:51:49 -07:00
2020-12-14 15:26:13 +01:00
2020-11-20 14:45:33 +11:00
2020-12-15 12:13:40 -08:00
2020-12-20 17:17:25 -08:00
2020-12-20 17:17:01 -08:00
2020-09-01 09:19:43 +02:00
2020-12-15 12:13:45 -08:00
2020-12-19 11:18:38 -08:00
2020-10-25 14:51:49 -07:00
2020-12-15 23:41:19 -08:00
2020-11-22 10:48:22 -08:00
2020-11-14 11:26:03 -08:00
2020-11-14 11:26:03 -08:00
2020-12-03 11:20:52 +01:00
2020-12-16 11:06:49 -08:00
2020-12-16 10:45:11 -08:00
2020-11-19 11:25:42 +01:00
2020-09-30 11:50:35 -07:00
2020-10-16 11:11:21 -07:00
2020-09-28 19:47:41 +02:00
2020-09-17 10:19:52 +03:00
2020-10-25 14:51:49 -07:00
2020-12-15 19:24:18 +01:00
2020-11-10 18:38:58 +01:00
2020-10-16 17:21:51 +02:00
2020-11-10 18:39:00 +01:00
2020-10-13 15:58:10 -07:00
2020-10-28 14:55:36 +01:00
2020-10-19 14:28:30 -07:00
2020-12-15 22:46:15 -08:00
2020-09-15 13:51:08 +02:00
2020-10-30 08:37:39 +01:00
2020-09-24 21:56:24 +02:00
2020-09-22 11:27:48 +02:00
2020-12-11 14:10:44 +01:00
2020-09-29 17:50:10 +09:00
2020-10-26 11:50:51 +09:00
2020-10-07 18:08:41 -04:00
2020-12-09 19:14:48 +01:00
2020-12-15 10:57:29 +01:00
2020-11-11 17:30:39 +01:00
2020-10-06 07:07:06 +02:00
2020-09-25 06:12:25 +02:00
2020-11-25 12:03:48 +00:00
2020-12-22 13:19:43 -08:00
2020-12-16 16:38:41 -08:00
2020-12-11 21:20:08 +05:30
2020-10-25 14:51:49 -07:00
2020-12-14 11:51:46 +01:00
2020-09-10 18:19:16 +02:00
2020-12-14 16:24:19 +01:00
2020-10-26 13:46:47 +01:00
2020-12-11 14:02:14 -08:00
2020-12-08 18:21:16 +01:00
2020-12-16 12:33:35 -08:00
2020-10-29 09:37:36 +01:00
2020-11-20 12:51:53 -08:00
2020-11-15 09:49:10 -05:00
2020-10-25 20:02:08 -04:00
2020-10-25 14:51:49 -07:00
2020-12-09 09:39:38 -05:00
2020-12-02 22:00:22 -08:00
2020-10-16 11:11:22 -07:00
2020-09-16 19:27:43 -04:00
2020-12-10 12:42:59 -06:00
2020-12-14 12:18:19 -08:00
2020-10-25 14:51:49 -07:00
2020-11-16 16:31:41 +01:00
2020-10-12 18:27:28 +02:00
2020-09-16 19:12:27 -04:00
2020-12-25 10:54:29 -08:00
2020-12-17 11:18:00 -08:00
2020-12-11 11:40:43 +01:00
2020-11-13 12:15:28 -05:00
2020-12-09 19:14:48 +01:00
2020-12-01 14:53:40 -07:00
2020-11-16 08:08:54 -08:00
2020-12-15 12:13:41 -08:00
2020-10-28 13:44:43 +01:00
2020-12-02 20:20:05 +01:00
2020-11-27 15:44:21 +01:00
2020-11-24 14:42:09 +01:00
2020-12-15 12:53:37 -08:00
2020-10-22 22:44:35 +02:00
2020-11-16 15:20:01 +01:00
2020-12-15 12:13:44 -08:00
2020-10-02 13:16:33 +02:00
2020-09-23 09:42:39 -07:00
2020-11-17 10:54:18 +00:00
2020-09-09 10:22:40 +02:00
2020-09-09 10:38:28 +02:00
2020-09-21 11:45:43 +02:00
2020-11-16 08:14:30 -07:00
2020-10-12 12:08:35 +02:00
2020-10-16 11:11:20 -07:00
2020-12-11 12:58:52 +01:00
2020-10-30 17:49:19 -07:00
2020-12-03 08:21:29 -08:00
2020-12-16 11:06:07 -08:00
2020-09-03 15:17:28 -07:00
2020-11-11 16:41:31 -08:00
2020-10-25 14:51:49 -07:00
2020-12-01 10:46:27 +01:00
2020-12-02 22:10:35 -08:00
2020-10-16 17:35:36 +02:00
2021-01-07 14:35:14 +00:00
2020-09-17 19:21:16 +02:00
2020-09-18 09:13:40 +03:00
2020-09-08 16:28:49 +03:00
2020-12-15 16:19:30 +01:00
2020-11-04 10:22:56 -07:00
2020-11-24 14:42:09 +01:00
2020-12-08 15:23:37 +00:00
2020-11-23 14:16:55 +00:00
2020-10-20 07:10:14 -06:00
2020-11-04 08:52:46 -08:00
2020-12-15 22:46:15 -08:00
2020-12-08 15:11:58 +00:00
2020-09-25 16:30:06 +02:00
2020-12-15 16:39:06 -08:00
2020-12-08 14:14:48 +00:00
2020-09-16 08:54:53 -05:00
2020-08-31 13:08:10 -07:00
2020-11-24 16:47:48 +01:00
2020-12-15 16:19:30 +01:00
2020-12-15 16:19:31 +01:00
2020-12-15 15:03:31 -08:00
2020-11-24 16:47:49 +01:00
2020-10-08 18:00:08 +02:00
2020-12-09 09:39:37 -05:00
2020-12-17 13:30:45 -05:00
2020-10-29 13:17:58 -05:00
2020-10-16 11:11:19 -07:00
2020-12-22 12:55:08 -08:00
2020-12-22 12:55:09 -08:00
2020-11-04 16:43:38 +01:00
2020-10-05 13:37:04 +02:00
2020-12-15 16:19:31 +01:00
2020-09-04 12:46:06 +01:00
2020-12-15 22:46:15 -08:00
2020-11-09 18:12:39 +01:00
2020-11-23 18:09:29 +00:00
2020-09-28 12:14:08 +01:00
2020-10-11 10:31:11 -07:00
2020-12-17 13:22:17 -08:00
2020-09-04 09:25:20 -07:00
2020-11-15 09:49:15 -05:00
2020-11-15 09:49:16 -05:00
2020-09-02 11:31:23 -06:00
2020-10-25 14:51:49 -07:00
2020-11-19 19:37:16 -08:00
2020-11-09 21:07:00 +09:00
2020-10-12 18:27:27 +02:00
2020-10-09 08:53:08 +02:00
2020-12-15 13:22:29 -08:00
2020-12-15 22:46:16 -08:00
2020-12-03 12:56:03 -08:00
2020-12-16 11:01:04 -08:00
2020-11-23 18:36:21 -05:00
2020-10-30 17:11:44 -07:00
2020-10-15 07:49:46 +02:00
2020-12-15 22:46:15 -08:00
2020-12-03 16:21:07 -07:00
2020-09-23 18:02:49 -07:00
2020-12-07 10:29:57 +01:00
2020-11-17 17:38:25 +02:00
2020-12-19 11:18:37 -08:00
2020-12-17 13:34:25 -08:00
2020-10-13 18:38:28 -07:00
2020-09-28 12:16:13 +02:00
2020-12-15 14:10:09 -08:00
2020-09-11 17:41:55 -07:00
2020-12-15 12:13:45 -08:00
2020-10-16 11:11:19 -07:00
2020-12-15 14:55:10 -08:00
2020-12-22 12:55:09 -08:00
2020-09-04 12:46:07 +01:00
2020-12-15 12:13:41 -08:00
2020-12-19 11:18:37 -08:00
2020-12-15 14:48:04 -08:00
2020-12-04 12:23:25 +01:00
2020-12-17 13:01:31 -08:00
2020-12-22 12:55:08 -08:00
2020-11-25 15:45:11 +01:00
2020-09-25 17:48:54 +10:00
2020-10-28 20:26:25 +01:00
2020-12-04 22:32:40 +01:00
2020-11-03 16:53:55 -08:00
2020-12-16 11:43:25 -08:00
2020-10-30 12:57:39 +01:00
2020-10-30 12:57:39 +01:00
2020-10-21 18:24:08 -07:00
2020-12-09 09:39:38 -05:00
2020-10-07 14:28:39 -04:00
2020-12-02 14:05:52 -05:00
2020-11-30 10:52:22 -05:00
2020-10-21 10:31:20 -04:00
2020-12-02 14:05:52 -05:00
2020-09-22 13:58:40 +02:00
2020-10-16 11:11:18 -07:00
2020-10-16 11:11:19 -07:00
2020-09-01 09:58:03 +02:00
2020-11-22 10:48:22 -08:00
2020-11-27 16:10:06 +01:00
2020-10-25 14:51:49 -07:00
2020-09-24 19:49:36 -07:00
2020-12-15 14:02:26 -08:00
2020-09-25 17:48:54 +10:00
2020-10-13 18:38:35 -07:00
2020-10-17 11:18:18 -07:00
2020-12-15 12:13:38 -08:00
2020-10-16 11:11:15 -07:00
2020-09-25 18:01:48 -04:00
2020-12-22 12:55:08 -08:00
2020-12-15 14:55:10 -08:00
2020-11-22 10:48:22 -08:00
2020-12-15 12:13:39 -08:00
2020-12-01 14:53:40 -07:00
2020-12-04 11:18:42 -06:00
2020-12-10 14:55:49 -06:00
2020-09-17 16:44:03 -05:00
2020-12-15 15:11:08 -06:00
2020-08-31 12:52:33 -07:00
2020-09-11 09:30:01 +03:00
2020-10-25 14:51:49 -07:00
2020-10-06 07:29:36 -06:00
2020-09-16 16:26:56 +02:00
2020-11-26 13:16:55 +01:00
2020-11-09 18:12:34 +01:00
2020-12-14 17:34:12 -08:00
2020-12-16 13:08:18 -08:00
2020-08-31 12:52:33 -07:00
2020-10-18 09:27:10 -07:00
2020-10-01 19:14:36 -07:00
2020-12-15 15:03:31 -08:00
2020-12-15 15:26:14 +01:00
2020-12-09 11:21:11 +05:30
2020-11-16 09:37:01 -08:00
2020-11-23 18:34:55 +01:00
2020-09-28 16:38:11 +02:00
2020-12-15 12:13:46 -08:00
2020-09-10 19:27:59 +02:00
2020-10-24 20:21:57 +02:00
2020-12-15 15:03:31 -08:00
2020-09-14 09:45:34 -07:00
2020-10-25 14:51:49 -07:00
2020-12-15 22:46:15 -08:00
2020-12-09 19:10:21 +01:00
2020-09-11 21:47:10 -07:00
2020-12-04 08:44:24 +00:00
2020-12-01 12:01:03 -08:00
2020-11-23 13:43:07 -08:00
2020-11-18 10:51:17 -08:00
2020-11-20 14:45:33 +11:00
2020-12-17 14:19:01 +01:00
2020-09-14 15:45:25 +02:00
2020-10-28 09:23:04 -05:00
2020-11-03 11:16:04 +01:00
2020-09-17 13:00:46 -04:00
2020-10-13 08:41:26 -04:00
2020-10-13 18:38:28 -07:00
2020-09-10 11:19:29 +02:00
2020-12-15 22:46:15 -08:00
2020-11-02 17:09:59 -08:00
2020-11-02 17:10:01 -08:00
2020-11-06 16:59:11 -08:00
2020-11-06 16:59:11 -08:00
2020-12-03 11:20:52 +01:00
2020-11-26 20:03:02 +00:00
2020-11-26 22:05:42 +11:00
2020-12-15 22:46:18 -08:00
2020-12-10 13:14:37 -06:00
2020-11-16 17:05:28 +01:00
2020-12-11 12:47:17 +01:00
2020-12-15 22:46:18 -08:00
2020-12-15 12:13:39 -08:00
2020-10-04 19:51:43 -07:00
2020-11-24 10:11:52 -06:00
2020-12-20 10:12:06 -08:00
2020-12-15 15:57:25 -08:00
2020-12-09 17:08:42 +01:00
2020-11-30 02:13:02 +01:00
2020-12-07 17:12:49 -07:00
2020-11-02 14:42:57 +01:00
2020-12-22 12:55:07 -08:00
2020-12-16 16:38:41 -08:00
2020-12-01 11:23:34 +00:00
2020-10-30 15:24:40 -07:00
2020-12-16 11:30:10 -08:00
2020-12-16 11:01:04 -08:00
2020-12-07 18:25:02 -05:00
2020-11-06 10:05:18 -08:00
2020-12-09 17:08:49 +01:00
2020-11-13 15:28:12 +01:00
2020-12-07 10:40:32 +01:00
2020-10-31 12:44:36 +01:00
2020-12-15 12:13:43 -08:00
2020-12-15 12:13:39 -08:00
2020-11-23 10:31:06 -06:00
2020-11-23 10:31:06 -06:00
2020-12-10 16:17:15 +01:00
2020-12-01 11:26:19 -08:00
2020-10-11 18:09:44 -07:00
2020-12-15 12:13:37 -08:00
2020-09-04 11:50:50 -07:00
2020-11-24 16:47:49 +01:00
2020-09-30 11:50:35 -07:00
2020-11-23 09:15:15 -07:00
2020-10-25 14:51:49 -07:00
2020-10-22 14:15:51 -06:00
2020-12-10 10:45:36 +01:00
2020-09-19 13:13:39 -07:00
2020-09-18 14:24:16 +01:00
2020-09-26 22:55:05 -04:00
2020-09-18 16:45:50 -04:00
2020-09-01 09:58:06 +02:00
2020-10-02 21:18:25 +02:00
2020-12-08 14:52:29 -08:00
2020-11-10 18:38:57 +01:00
2020-09-30 10:50:30 +02:00
2020-12-22 12:55:08 -08:00
2020-09-23 10:43:19 -06:00
2020-10-13 18:38:30 -07:00
2020-12-15 14:48:04 -08:00
2020-12-11 15:43:41 -05:00
2020-12-02 15:07:56 +01:00
2020-12-19 11:18:38 -08:00
2020-10-02 12:02:30 +02:00
2020-10-17 15:05:30 -06:00
2020-09-10 13:15:40 -07:00
2020-12-11 14:11:13 +01:00
2020-12-02 15:07:56 +01:00
2020-11-11 10:20:16 +03:00
2020-10-26 11:48:11 +01:00
2020-12-14 16:40:27 -08:00
2020-10-30 21:57:04 +01:00
2020-12-16 00:07:17 -08:00
2020-11-16 15:20:01 +01:00
2020-12-11 10:40:52 +01:00
2020-09-16 22:05:18 +10:00
2020-10-25 14:51:49 -07:00
2020-11-10 20:39:40 -05:00
2020-12-07 18:25:02 -05:00
2020-10-05 12:43:53 +02:00
2020-12-16 12:33:35 -08:00
2020-10-15 15:51:28 -07:00
2020-10-25 14:51:49 -07:00
2020-12-04 16:54:35 +01:00
2020-12-09 15:27:42 +01:00
2020-09-17 19:21:16 +02:00
2020-10-24 10:57:57 -07:00
2020-11-09 18:39:36 +01:00
2020-10-12 16:35:51 -07:00
2020-09-10 14:03:31 -07:00
2020-12-15 22:46:15 -08:00
2020-12-09 20:00:26 +01:00
2020-09-25 16:33:58 +02:00
2020-12-18 16:14:31 -05:00
2020-12-10 14:47:56 -07:00
2020-09-08 13:33:11 +02:00
2020-10-23 11:00:57 -07:00
2020-09-04 09:31:54 -07:00
2020-12-15 12:13:41 -08:00
2020-12-15 12:13:40 -08:00
2020-12-02 20:20:05 +01:00
2020-10-05 13:21:49 +02:00
2020-11-15 09:49:09 -05:00
2020-10-01 09:40:35 -04:00
2020-10-20 14:39:37 -07:00
2020-12-06 10:19:07 -08:00