Files
rockchip-kernel/include/linux
Gustavo A. R. Silva bb4cf02d4c netdevice: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-03-02 11:16:27 -08:00
..
2020-02-16 18:30:41 -08:00
2019-12-11 09:12:38 +01:00
2019-11-12 11:43:29 -05:00
2020-01-27 14:35:32 +01:00
2020-01-23 12:37:18 +00:00
2020-02-04 03:05:26 +00:00
2020-02-04 03:05:26 +00:00
2020-02-27 18:50:19 -08:00
2019-11-26 10:26:26 +01:00
2020-01-23 00:35:50 +01:00
2020-02-26 20:07:25 -08:00
2019-10-09 19:33:43 -07:00
2019-12-03 11:20:37 +01:00
2020-01-27 11:09:31 +01:00
2020-01-17 16:48:07 -08:00
2020-01-18 09:19:18 -05:00
2020-01-13 21:48:42 +01:00
2019-11-20 09:40:10 +01:00
2019-12-01 12:59:06 -08:00
2019-10-04 12:31:46 -07:00
2019-10-15 13:34:25 +02:00
2019-11-11 09:02:56 +01:00
2019-12-04 19:44:14 -08:00
2020-01-31 17:33:54 +00:00
2020-02-20 21:17:24 +01:00
2019-12-11 09:12:38 +01:00
2020-02-17 12:52:38 +01:00
2020-02-04 07:24:48 +00:00
2019-12-09 10:55:03 +01:00
2019-11-14 19:06:47 -08:00
2020-01-15 10:54:33 -05:00
2020-01-14 12:20:48 +01:00
2019-12-11 16:37:02 +08:00
2019-11-13 19:09:47 +08:00
2020-01-16 17:09:18 +01:00
2020-01-15 16:30:28 +00:00
2020-01-29 17:00:02 -06:00
2020-02-24 15:31:23 -08:00
2019-12-06 10:47:28 +01:00
2020-01-13 18:16:43 -08:00
2020-01-10 14:00:58 -08:00
2020-01-24 10:24:31 -08:00
2020-01-24 10:24:31 -08:00
2019-11-14 13:07:48 +08:00
2019-10-10 14:55:24 -07:00
2020-02-04 03:05:24 +00:00
2019-11-13 12:15:34 -08:00
2020-01-13 18:31:48 -08:00
2020-02-04 03:05:26 +00:00
2020-02-26 20:07:25 -08:00
2020-02-21 11:22:15 -08:00
2020-01-14 12:20:48 +01:00
2019-11-14 12:20:02 +08:00
2020-01-17 22:33:37 -05:00