Maxime Chevallier c5ed0eaddc net: ethtool: Don't call .cleanup_data when prepare_data fails ...

[ Upstream commit 4f038a6a02d20859a3479293cbf172b0f14cbdd6 ]

There's a consistent pattern where the .cleanup_data() callback is
called when .prepare_data() fails, when it should really be called to
clean after a successful .prepare_data() as per the documentation.

Rewrite the error-handling paths to make sure we don't cleanup
un-prepared data.

Fixes: c781ff12a2 ("ethtool: Allow network drivers to dump arbitrary EEPROM data")
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://patch.msgid.link/20250407130511.75621-1-maxime.chevallier@bootlin.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2025-04-25 10:45:07 +02:00

..

bitset.c

ethtool: Fix wrong mod state in case of verbose and no_mask bitset

2024-12-14 19:59:39 +01:00

bitset.h

ethtool: add ethnl_parse_bitset() helper

2020-03-12 15:32:32 -07:00

cabletest.c

net: delete extra space and tab in blank line

2022-07-25 19:38:31 -07:00

channels.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

coalesce.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

common.c

net: transfer rtnl_lock() requirement from ethtool_set_ethtool_phy_ops() to caller

2023-08-02 19:11:06 -07:00

common.h

net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC)

2023-01-23 12:44:18 +00:00

debug.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

eee.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

eeprom.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

features.c

ethtool: netlink: Add missing ethnl_ops_begin/complete

2024-01-25 15:36:00 -08:00

fec.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

ioctl.c

ethtool: check device is present when getting link settings

2024-09-04 13:28:26 +02:00

linkinfo.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

linkmodes.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

linkstate.c

ethtool: netlink: do not return SQI value if link is down

2024-07-18 13:21:14 +02:00

Makefile

net: ethtool: add support for MAC Merge layer

2023-01-23 12:44:18 +00:00

mm.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

module.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

netlink.c

net: ethtool: Don't call .cleanup_data when prepare_data fails

2025-04-25 10:45:07 +02:00

netlink.h

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

pause.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

phc_vclocks.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

plca.c

ethtool: plca: fix plca enable data type while parsing the value

2023-10-03 07:18:58 -07:00

privflags.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

pse-pd.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

rings.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

rss.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

stats.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

strset.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

tsinfo.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00

tunnels.c

genetlink: use attrs from struct genl_info

2023-08-15 15:00:45 -07:00

wol.c

ethtool: netlink: always pass genl_info to .prepare_data

2023-08-15 15:01:03 -07:00