mirros/rockchip-kernel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Compiler Attributes: homogenize __must_be_array

Browse Source 
Different definitions of __must_be_array:

  * gcc: disabled for __CHECKER__

  * clang: same definition as gcc's, but without __CHECKER__

  * intel: the comment claims __builtin_types_compatible_p()
    is unsupported; but icc seems to support it since 13.0.1
    (released in 2012). See https://godbolt.org/z/S0l6QQ

Therefore, we can remove all of them and have a single definition
in compiler.h

Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # on top of v4.19-rc5, clang 7
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
This commit is contained in:
Miguel Ojeda
2018-08-30 19:25:14 +02:00
parent c2c640aa04
commit ec0bbef66f
4 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
include/linux/compiler-clang.h
View File

@@ -41,6 +41,5 @@
* compilers, like ICC. * compilers, like ICC.
*/ */
#define barrier() __asm__ __volatile__("" : : : "memory") #define barrier() __asm__ __volatile__("" : : : "memory")
#define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
#define __assume_aligned(a, ...) \ #define __assume_aligned(a, ...) \
__attribute__((__assume_aligned__(a, ## __VA_ARGS__))) __attribute__((__assume_aligned__(a, ## __VA_ARGS__)))

7
include/linux/compiler-gcc.h
View File

@@ -68,13 +68,6 @@
*/ */
#define uninitialized_var(x) x = x #define uninitialized_var(x) x = x
#ifdef __CHECKER__
#define __must_be_array(a) 0
#else
/* &a[0] degrades to a pointer: a different type from an array */
#define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
#endif
#ifdef RETPOLINE #ifdef RETPOLINE
#define __noretpoline __attribute__((__indirect_branch__("keep"))) #define __noretpoline __attribute__((__indirect_branch__("keep")))
#endif #endif

3
include/linux/compiler-intel.h
View File

@@ -29,9 +29,6 @@
*/ */
#define OPTIMIZER_HIDE_VAR(var) barrier() #define OPTIMIZER_HIDE_VAR(var) barrier()
/* Intel ECC compiler doesn't support __builtin_types_compatible_p() */
#define __must_be_array(a) 0
#endif #endif
/* icc has this, but it's called _bswap16 */ /* icc has this, but it's called _bswap16 */

7
include/linux/compiler.h
View File

@@ -357,4 +357,11 @@ static inline void *offset_to_ptr(const int *off)
compiletime_assert(__native_word(t), \ compiletime_assert(__native_word(t), \
"Need native word sized stores/loads for atomicity.") "Need native word sized stores/loads for atomicity.")
#ifdef __CHECKER__
#define __must_be_array(a) 0
#else
/* &a[0] degrades to a pointer: a different type from an array */
#define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
#endif
#endif /* __LINUX_COMPILER_H */ #endif /* __LINUX_COMPILER_H */