mirros/rockchip-kernel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pinctrl: rza1: Remove unneeded spinlock acquisitions

Browse Source 
rza1_get_bit() is just a single register read.  Hence there's no need to
synchronize it with other register writes to the same bank.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
Geert Uytterhoeven
2018-11-13 09:38:35 +01:00
parent fa4d36712f
commit e005da0ef7
1 changed files with 2 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/pinctrl/pinctrl-rza1.c
View File

@@ -620,14 +620,7 @@ static void rza1_pin_reset(struct rza1_port *port, unsigned int pin)
static inline int rza1_pin_get_direction(struct rza1_port *port, static inline int rza1_pin_get_direction(struct rza1_port *port,
unsigned int pin) unsigned int pin)
{ {
unsigned long irqflags; return !!rza1_get_bit(port, RZA1_PM_REG, pin);
int input;
spin_lock_irqsave(&port->lock, irqflags);
input = rza1_get_bit(port, RZA1_PM_REG, pin);
spin_unlock_irqrestore(&port->lock, irqflags);
return !!input;
} }
/** /**
@@ -671,14 +664,7 @@ static inline void rza1_pin_set(struct rza1_port *port, unsigned int pin,
static inline int rza1_pin_get(struct rza1_port *port, unsigned int pin) static inline int rza1_pin_get(struct rza1_port *port, unsigned int pin)
{ {
unsigned long irqflags; return rza1_get_bit(port, RZA1_PPR_REG, pin);
int val;
spin_lock_irqsave(&port->lock, irqflags);
val = rza1_get_bit(port, RZA1_PPR_REG, pin);
spin_unlock_irqrestore(&port->lock, irqflags);
return val;
} }
/** /**