mirros/rockchip-kernel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fs: read_mapping_page() should take a struct file argument

Browse Source 
While read_cache_page() takes a void *, because you can pass a
pointer to anything as the first argument of filler_t, if we
are calling read_mapping_page(), it will be passed as the first
argument of ->readpage, so we know this must be a struct file
pointer, and we should let the compiler enforce that for us.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Tested-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Tested-by: Mike Marshall <hubcap@omnibond.com> # orangefs
Tested-by: David Howells <dhowells@redhat.com> # afs
This commit is contained in:
Matthew Wilcox (Oracle)
2022-02-09 20:21:23 +00:00
parent 1241ebeca3
commit c14c6843ae
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
include/linux/pagemap.h
View File

@@ -636,15 +636,15 @@ extern int read_cache_pages(struct address_space *mapping,
struct list_head *pages, filler_t *filler, void *data); struct list_head *pages, filler_t *filler, void *data);
static inline struct page *read_mapping_page(struct address_space *mapping, static inline struct page *read_mapping_page(struct address_space *mapping,
pgoff_t index, void *data) pgoff_t index, struct file *file)
{ {
return read_cache_page(mapping, index, NULL, data); return read_cache_page(mapping, index, NULL, file);
} }
static inline struct folio *read_mapping_folio(struct address_space *mapping, static inline struct folio *read_mapping_folio(struct address_space *mapping,
pgoff_t index, void *data) pgoff_t index, struct file *file)
{ {
return read_cache_folio(mapping, index, NULL, data); return read_cache_folio(mapping, index, NULL, file);
} }
/* /*