From ac1ada90c9edf815f4eddb9bea4a7ad4283a6189 Mon Sep 17 00:00:00 2001 From: Sandy Huang Date: Tue, 24 Dec 2024 10:44:57 +0800 Subject: [PATCH] drm/rockchip: vop: fix clang compile warning drivers/gpu/drm/rockchip/rockchip_drm_vop.c:2927:2: warning: Access to field 'data' results in a dereference of a null pointer (loaded from variable 'vop') [core.NullDereference] Signed-off-by: Sandy Huang Change-Id: I1cb0f43434b3b0aca31fd83f29016668961d95f5 --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index e2dbb7187138..ef36d7a3b677 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -2921,13 +2921,15 @@ static void vop_set_out_mode(struct vop *vop, u32 mode) int ret; u32 val; + if (!vop) + return; + VOP_CTRL_SET(vop, out_mode, mode); vop_cfg_done(vop); ret = readx_poll_timeout(vop_mode_done, vop, val, val == mode, 1000, 500 * 1000); if (ret) dev_err(vop->dev, "wait mode 0x%x timeout\n", mode); - } static void vop_crtc_send_mcu_cmd(struct drm_crtc *crtc, u32 type, u32 value)