mirros/rockchip-kernel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

decnet: Do not build routes to devices without decnet private data.

Browse Source 
In particular, make sure we check for decnet private presence
for loopback devices.

Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
David S. Miller
2016-04-10 23:01:30 -04:00
parent ba6f5e33bd
commit a36a0d4008
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
net/decnet/dn_route.c
View File

@@ -1034,10 +1034,13 @@ source_ok:
if (!fld.daddr) { if (!fld.daddr) {
fld.daddr = fld.saddr; fld.daddr = fld.saddr;
err = -EADDRNOTAVAIL;
if (dev_out) if (dev_out)
dev_put(dev_out); dev_put(dev_out);
err = -EINVAL;
dev_out = init_net.loopback_dev; dev_out = init_net.loopback_dev;
if (!dev_out->dn_ptr)
goto out;
err = -EADDRNOTAVAIL;
dev_hold(dev_out); dev_hold(dev_out);
if (!fld.daddr) { if (!fld.daddr) {
fld.daddr = fld.daddr =
@@ -1110,6 +1113,8 @@ source_ok:
if (dev_out == NULL) if (dev_out == NULL)
goto out; goto out;
dn_db = rcu_dereference_raw(dev_out->dn_ptr); dn_db = rcu_dereference_raw(dev_out->dn_ptr);
if (!dn_db)
goto e_inval;
/* Possible improvement - check all devices for local addr */ /* Possible improvement - check all devices for local addr */
if (dn_dev_islocal(dev_out, fld.daddr)) { if (dn_dev_islocal(dev_out, fld.daddr)) {
dev_put(dev_out); dev_put(dev_out);
@@ -1151,6 +1156,8 @@ select_source:
dev_put(dev_out); dev_put(dev_out);
dev_out = init_net.loopback_dev; dev_out = init_net.loopback_dev;
dev_hold(dev_out); dev_hold(dev_out);
if (!dev_out->dn_ptr)
goto e_inval;
fld.flowidn_oif = dev_out->ifindex; fld.flowidn_oif = dev_out->ifindex;
if (res.fi) if (res.fi)
dn_fib_info_put(res.fi); dn_fib_info_put(res.fi);