mirros/rockchip-kernel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

devtmpfs: remove return value of devtmpfs_delete_node()

Browse Source 
The only caller of device_del() does not check the return value. And
there's nothing we can do when cleaning things up on a remove path.
Let's make it a void function.

Signed-off-by: Longlong Xia <xialonglong1@huawei.com>
Link: https://lore.kernel.org/r/20230210095444.4067307-4-xialonglong1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Longlong Xia
2023-02-10 09:54:44 +00:00
committed by Greg Kroah-Hartman
parent 90a9d5ff22
commit 9d3fe6aa6b
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/base/base.h
View File

@@ -215,10 +215,10 @@ void device_pm_move_to_tail(struct device *dev);
#ifdef CONFIG_DEVTMPFS #ifdef CONFIG_DEVTMPFS
int devtmpfs_create_node(struct device *dev); int devtmpfs_create_node(struct device *dev);
int devtmpfs_delete_node(struct device *dev); void devtmpfs_delete_node(struct device *dev);
#else #else
static inline int devtmpfs_create_node(struct device *dev) { return 0; } static inline int devtmpfs_create_node(struct device *dev) { return 0; }
static inline int devtmpfs_delete_node(struct device *dev) { return 0; } static inline void devtmpfs_delete_node(struct device *dev) { }
#endif #endif
void software_node_notify(struct device *dev); void software_node_notify(struct device *dev);

8
drivers/base/devtmpfs.c
View File

@@ -147,22 +147,22 @@ int devtmpfs_create_node(struct device *dev)
return devtmpfs_submit_req(&req, tmp); return devtmpfs_submit_req(&req, tmp);
} }
int devtmpfs_delete_node(struct device *dev) void devtmpfs_delete_node(struct device *dev)
{ {
const char *tmp = NULL; const char *tmp = NULL;
struct req req; struct req req;
if (!thread) if (!thread)
return 0; return;
req.name = device_get_devnode(dev, NULL, NULL, NULL, &tmp); req.name = device_get_devnode(dev, NULL, NULL, NULL, &tmp);
if (!req.name) if (!req.name)
return -ENOMEM; return;
req.mode = 0; req.mode = 0;
req.dev = dev; req.dev = dev;
return devtmpfs_submit_req(&req, tmp); devtmpfs_submit_req(&req, tmp);
} }
static int dev_mkdir(const char *name, umode_t mode) static int dev_mkdir(const char *name, umode_t mode)