mirros/rockchip-kernel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

thermal/drivers/imx_sc_thermal: Fix refcount leak in imx_sc_thermal_probe

Browse Source 
[ Upstream commit 09700c504d ]

of_find_node_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: e20db70dba ("thermal: imx_sc: add i.MX system controller thermal support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220517055121.18092-1-linmq006@gmail.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Miaoqian Lin
2022-05-17 09:51:21 +04:00
committed by Greg Kroah-Hartman
parent 18530bedd2
commit 8bbf522a2c
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/thermal/imx_sc_thermal.c
View File

@@ -94,8 +94,8 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
sensor = devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL); sensor = devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL);
if (!sensor) { if (!sensor) {
of_node_put(child); of_node_put(child);
of_node_put(sensor_np); ret = -ENOMEM;
return -ENOMEM; goto put_node;
} }
ret = thermal_zone_of_get_sensor_id(child, ret = thermal_zone_of_get_sensor_id(child,
@@ -124,7 +124,9 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
dev_warn(&pdev->dev, "failed to add hwmon sysfs attributes\n"); dev_warn(&pdev->dev, "failed to add hwmon sysfs attributes\n");
} }
put_node:
of_node_put(sensor_np); of_node_put(sensor_np);
of_node_put(np);
return ret; return ret;
} }