mirros/rockchip-kernel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gpio: amd8111: Fix PCI device reference count leak

Browse Source 
[ Upstream commit 45fecdb9f6 ]

for_each_pci_dev() is implemented by pci_get_device(). The comment of
pci_get_device() says that it will increase the reference count for the
returned pci_dev and also decrease the reference count for the input
pci_dev @from if it is not NULL.

If we break for_each_pci_dev() loop with pdev not NULL, we need to call
pci_dev_put() to decrease the reference count. Add the missing
pci_dev_put() after the 'out' label. Since pci_dev_put() can handle NULL
input parameter, there is no problem for the 'Device not found' branch.
For the normal path, add pci_dev_put() in amd_gpio_exit().

Fixes: f942a7de04 ("gpio: add a driver for GPIO pins found on AMD-8111 south bridge chips")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Xiongfeng Wang
2022-11-22 20:35:08 +08:00
committed by Greg Kroah-Hartman
parent b9aca69a6c
commit 5ee6413d3d
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpio/gpio-amd8111.c
View File

@@ -231,7 +231,10 @@ found:
ioport_unmap(gp.pm); ioport_unmap(gp.pm);
goto out; goto out;
} }
return 0;
out: out:
pci_dev_put(pdev);
return err; return err;
} }
@@ -239,6 +242,7 @@ static void __exit amd_gpio_exit(void)
{ {
gpiochip_remove(&gp.chip); gpiochip_remove(&gp.chip);
ioport_unmap(gp.pm); ioport_unmap(gp.pm);
pci_dev_put(gp.pdev);
} }
module_init(amd_gpio_init); module_init(amd_gpio_init);