mirros/rockchip-kernel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

powerpc/fsl_rio: Fix refcount leak in fsl_rio_setup

Browse Source 
[ Upstream commit fcee96924b ]

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: abc3aeae3a ("fsl-rio: Add two ports and rapidio message units support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220512123724.62931-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Miaoqian Lin
2022-05-12 16:37:18 +04:00
committed by Greg Kroah-Hartman
parent b8ef79697b
commit 46fd994763
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
arch/powerpc/sysdev/fsl_rio.c
View File

@@ -505,8 +505,10 @@ int fsl_rio_setup(struct platform_device *dev)
if (rc) { if (rc) {
dev_err(&dev->dev, "Can't get %pOF property 'reg'\n", dev_err(&dev->dev, "Can't get %pOF property 'reg'\n",
rmu_node); rmu_node);
of_node_put(rmu_node);
goto err_rmu; goto err_rmu;
} }
of_node_put(rmu_node);
rmu_regs_win = ioremap(rmu_regs.start, resource_size(&rmu_regs)); rmu_regs_win = ioremap(rmu_regs.start, resource_size(&rmu_regs));
if (!rmu_regs_win) { if (!rmu_regs_win) {
dev_err(&dev->dev, "Unable to map rmu register window\n"); dev_err(&dev->dev, "Unable to map rmu register window\n");