x86/mm/tlb: Restructure switch_mm_irqs_off()
Move some code that will be needed for the lazy -> !lazy state
transition when a lazy TLB CPU has gotten out of date.
No functional changes, since the if (real_prev == next) branch
always returns.
(cherry picked from commit 61d0beb579)
Cc: npiggin@gmail.com
Cc: efault@gmx.de
Cc: will.deacon@arm.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: songliubraving@fb.com
Cc: kernel-team@fb.com
Cc: hpa@zytor.com
Suggested-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Rik van Riel <riel@surriel.com>
Acked-by: Dave Hansen <dave.hansen@intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180716190337.26133-4-riel@surriel.com
This commit is contained in:
committed by
Peter Zijlstra
parent
5462bc3a9a
commit
12c4d978fd
@@ -187,6 +187,8 @@ void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next,
|
|||||||
u16 prev_asid = this_cpu_read(cpu_tlbstate.loaded_mm_asid);
|
u16 prev_asid = this_cpu_read(cpu_tlbstate.loaded_mm_asid);
|
||||||
unsigned cpu = smp_processor_id();
|
unsigned cpu = smp_processor_id();
|
||||||
u64 next_tlb_gen;
|
u64 next_tlb_gen;
|
||||||
|
bool need_flush;
|
||||||
|
u16 new_asid;
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* NB: The scheduler will call us with prev == next when switching
|
* NB: The scheduler will call us with prev == next when switching
|
||||||
@@ -252,8 +254,6 @@ void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next,
|
|||||||
|
|
||||||
return;
|
return;
|
||||||
} else {
|
} else {
|
||||||
u16 new_asid;
|
|
||||||
bool need_flush;
|
|
||||||
u64 last_ctx_id = this_cpu_read(cpu_tlbstate.last_ctx_id);
|
u64 last_ctx_id = this_cpu_read(cpu_tlbstate.last_ctx_id);
|
||||||
|
|
||||||
/*
|
/*
|
||||||
@@ -308,6 +308,7 @@ void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next,
|
|||||||
/* Let nmi_uaccess_okay() know that we're changing CR3. */
|
/* Let nmi_uaccess_okay() know that we're changing CR3. */
|
||||||
this_cpu_write(cpu_tlbstate.loaded_mm, LOADED_MM_SWITCHING);
|
this_cpu_write(cpu_tlbstate.loaded_mm, LOADED_MM_SWITCHING);
|
||||||
barrier();
|
barrier();
|
||||||
|
}
|
||||||
|
|
||||||
if (need_flush) {
|
if (need_flush) {
|
||||||
this_cpu_write(cpu_tlbstate.ctxs[new_asid].ctx_id, next->context.ctx_id);
|
this_cpu_write(cpu_tlbstate.ctxs[new_asid].ctx_id, next->context.ctx_id);
|
||||||
@@ -344,7 +345,6 @@ void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next,
|
|||||||
|
|
||||||
this_cpu_write(cpu_tlbstate.loaded_mm, next);
|
this_cpu_write(cpu_tlbstate.loaded_mm, next);
|
||||||
this_cpu_write(cpu_tlbstate.loaded_mm_asid, new_asid);
|
this_cpu_write(cpu_tlbstate.loaded_mm_asid, new_asid);
|
||||||
}
|
|
||||||
|
|
||||||
load_mm_cr4(next);
|
load_mm_cr4(next);
|
||||||
switch_ldt(real_prev, next);
|
switch_ldt(real_prev, next);
|
||||||
|
|||||||
Reference in New Issue
Block a user