mirros/rockchip-kernel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: thunderx: Fix the ACPI memory leak

Browse Source 
[ Upstream commit 661e5ebbaf ]

The ACPI buffer memory (string.pointer) should be freed as the buffer is
not used after returning from bgx_acpi_match_id(), free it to prevent
memory leak.

Fixes: 46b903a01c ("net, thunder, bgx: Add support to get MAC address from ACPI.")
Signed-off-by: Yu Liao <liaoyu15@huawei.com>
Link: https://lore.kernel.org/r/20221123082237.1220521-1-liaoyu15@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Yu Liao
2022-11-23 16:22:36 +08:00
committed by Greg Kroah-Hartman
parent b034fe2a08
commit 11052f1188
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/cavium/thunder/thunder_bgx.c
View File

@@ -1438,8 +1438,10 @@ static acpi_status bgx_acpi_match_id(acpi_handle handle, u32 lvl,
return AE_OK; return AE_OK;
} }
if (strncmp(string.pointer, bgx_sel, 4)) if (strncmp(string.pointer, bgx_sel, 4)) {
kfree(string.pointer);
return AE_OK; return AE_OK;
}
acpi_walk_namespace(ACPI_TYPE_DEVICE, handle, 1, acpi_walk_namespace(ACPI_TYPE_DEVICE, handle, 1,
bgx_acpi_register_phy, NULL, bgx, NULL); bgx_acpi_register_phy, NULL, bgx, NULL);